Fixed up helloworld.js and README.md#2
Open
Ricardo-21 wants to merge 1 commit intoThe-Marcy-Lab-School:masterfrom
Open
Fixed up helloworld.js and README.md#2Ricardo-21 wants to merge 1 commit intoThe-Marcy-Lab-School:masterfrom
Ricardo-21 wants to merge 1 commit intoThe-Marcy-Lab-School:masterfrom
Conversation
thuyanduong
approved these changes
Sep 29, 2020
Member
thuyanduong
left a comment
thuyanduong
left a comment
There was a problem hiding this comment.
Great job, Ricardo!
You fixed all the bugs in helloworld.js and even added semicolons which is a JavaScript best practice. You've also made some improvements to README.md.
There are a few more improvements that could be made to this repository:
- The header "Instrcutions" is misspelled in README.md.
- The numbered list under "Instructions" has some errors. The first word of a sentence should be capitalized in "fork" and the misspelling of your as "ur".
- In the
README.md, the function descriptions are not complete sentences or have some grammatical errors. - Also, since you've updated the code, the comments are no longer applicable, so we can remove them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated and fixed both files to run properly